-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Happy new year ! #902
Happy new year ! #902
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit aacc58c:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy new year! That said, I don't believe you have to update the copyright every year. (The notice is technically not needed anyway, since you automatically get copyright over your works, but even so it generally refers to the creation date. Alternatively, we could do 2020 and later
or something like that?)
That's an excellent question. I'll bring it up to Aaron, who was updating the ESS code this way, and see if it is necessary. |
My understanding of copyright statements is that there are basically two approaches, but neither allows "2020 and later". One approach: The other approach: A third approach is to just omit the copyright portion, but I'm assuming that's a non-starter here. |
I think including the copyright notice in each source file is a legal recommendation, even though it may be more critical in the proprietary code than in the open code, as long as the overall project clearly shares a license (even though worst case scenario, the default license that applies is plain copyright, which is restrictive). In any case, since this header is checked by the linter, indeed keeping everything aligned is much easier :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I don't really care, just thought that this looks like exactly the type of manual work that won't be done reliably, but it's not a big issue either way - as far as I know, a copyright notice is a courtesy, not a requirement, and hence there's no clearly defined format either. Although it's especially unclear to me what "2021" means in this case for files that were wholly created in 2020. Like, does copyright not apply if the year mentioned is not the current year? :)
No description provided.