Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Happy new year ! #902

Merged
merged 4 commits into from
Jan 6, 2021
Merged

Happy new year ! #902

merged 4 commits into from
Jan 6, 2021

Conversation

NSeydoux
Copy link
Contributor

@NSeydoux NSeydoux commented Jan 4, 2021

No description provided.

@NSeydoux NSeydoux requested review from Vinnl and pmcb55 January 4, 2021 15:13
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 4, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit aacc58c:

Sandbox Source
solid-client-auth-browser-demo Configuration

Copy link
Contributor

@Vinnl Vinnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy new year! That said, I don't believe you have to update the copyright every year. (The notice is technically not needed anyway, since you automatically get copyright over your works, but even so it generally refers to the creation date. Alternatively, we could do 2020 and later or something like that?)

@NSeydoux
Copy link
Contributor Author

NSeydoux commented Jan 4, 2021

That's an excellent question. I'll bring it up to Aaron, who was updating the ESS code this way, and see if it is necessary.

@acoburn
Copy link
Contributor

acoburn commented Jan 4, 2021

My understanding of copyright statements is that there are basically two approaches, but neither allows "2020 and later".

One approach:
Say you have 10 files, each of which has a "Copyright 2020 ..." statement. If, at any point in 2021 you update some of those files, those files will need the "Copyright 2021 ..." statement. This will lead to different files having different copyright years. IMO, that becomes a pain to manage -- it's also harder to enforce with tooling, since you can't say "require all files to contain a copyright statement with 'Copyright 2021 ...' or the like".

The other approach:
Again, 10 files, and say you want to enforce having a copyright statement with tooling, it just ends up being easier to manage if you change everything in one fell swoop.

A third approach is to just omit the copyright portion, but I'm assuming that's a non-starter here.

@NSeydoux
Copy link
Contributor Author

NSeydoux commented Jan 5, 2021

I think including the copyright notice in each source file is a legal recommendation, even though it may be more critical in the proprietary code than in the open code, as long as the overall project clearly shares a license (even though worst case scenario, the default license that applies is plain copyright, which is restrictive).

In any case, since this header is checked by the linter, indeed keeping everything aligned is much easier :)

Copy link
Contributor

@Vinnl Vinnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I don't really care, just thought that this looks like exactly the type of manual work that won't be done reliably, but it's not a big issue either way - as far as I know, a copyright notice is a courtesy, not a requirement, and hence there's no clearly defined format either. Although it's especially unclear to me what "2021" means in this case for files that were wholly created in 2020. Like, does copyright not apply if the year mentioned is not the current year? :)

@vercel vercel bot temporarily deployed to Preview January 6, 2021 06:48 Inactive
@vercel vercel bot temporarily deployed to Preview January 6, 2021 07:10 Inactive
@vercel vercel bot temporarily deployed to Preview January 6, 2021 07:51 Inactive
@NSeydoux NSeydoux merged commit b17ddbc into master Jan 6, 2021
@NSeydoux NSeydoux deleted the chore/2021 branch January 6, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants