Lerna setup, and ESLint, Jest and TS configs refactored #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinnl
reviewed
Sep 3, 2020
There was a problem hiding this comment.
Added some suggestions inline.
I think it might be good to pull through and immediately also take the step of splitting the two packages, to ensure that it actually is possible to have the individual packages depend on each other. There's bound to be plenty of problems with this setup that will only be uncovered when actually using this as a monorepo, so you'd be doing more of this work when splitting the packages anyway.
Another significant litmus test will be updated the CD config, and then trying to use the published package in a clean project, to verify that everything looks and behaves as expected.
pmcb55
force-pushed
the
feat/setup-lerna
branch
from
731bc99 to
ff9c915
Compare
NSeydoux
reviewed
Sep 4, 2020
NSeydoux
reviewed
Sep 4, 2020
pmcb55
force-pushed
the
feat/setup-lerna
branch
4 times, most recently
from
9acb4a5 to
cec6ffe
Compare
|
It looks like |
NSeydoux
approved these changes
Sep 7, 2020
NSeydoux
force-pushed
the
feat/setup-lerna
branch
from
04f081e to
b4b2662
Compare
The default behavior is to look at the git history, but the preview does not push a tag into the history (see https://github.com/lerna/lerna/tree/master/commands/publish#readme for details).
Added a build step as a pre-publish step, and removed extraneous lerna bootstrap from preview CD.
Vinnl
reviewed
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to address: https://inrupt.atlassian.net/browse/SDK-1207
There are some specific changes here that need careful review TS config in particular.