Skip to content
This repository was archived by the owner on Jul 5, 2023. It is now read-only.

Add labels during namespace creation #99

Merged
merged 1 commit into from
May 20, 2020

Conversation

johscheuer
Copy link
Contributor

During debugging #98 I noticed that the namespace are not created properly:

$ kubectl get ns --show-labels
NAME                             STATUS   AGE   LABELS
default                          Active   3h    <none>
illuminatio                      Active   3h    <none>
illuminatio-inverted-roleadmin   Active   9m    illuminatio-cleanup=on-request
illuminatio-inverted-staging     Active   9m    illuminatio-cleanup=on-request
kube-public                      Active   3h    <none>
kube-system                      Active   3h    <none>
roleadmin                        Active   9m    illuminatio-cleanup=on-request
staging                          Active   3h    <none>

after the patch the labels are applied to the namespaces e.g. role=admin:

$ kubectl get ns --show-labels
NAME                             STATUS   AGE   LABELS
default                          Active   3h    <none>
illuminatio                      Active   3h    <none>
illuminatio-inverted-roleadmin   Active   16s   illuminatio-cleanup=on-request,illuminatio-inverted-role=admin
illuminatio-inverted-staging     Active   16s   illuminatio-cleanup=on-request
kube-public                      Active   3h    <none>
kube-system                      Active   3h    <none>
roleadmin                        Active   16s   illuminatio-cleanup=on-request,role=admin
staging                          Active   3h    <none>

@johscheuer johscheuer requested a review from maxbischoff May 12, 2020 17:48
@johscheuer johscheuer self-assigned this May 12, 2020
@johscheuer johscheuer added the bug Something isn't working label May 12, 2020
Copy link
Member

@maxbischoff maxbischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johscheuer johscheuer merged commit 086d2eb into inovex:master May 20, 2020
@johscheuer johscheuer deleted the fix-namespace-creation branch May 20, 2020 09:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants