Skip to content
This repository was archived by the owner on Jul 5, 2023. It is now read-only.

Limit length of created service names #122

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Limit length of created service names #122

merged 2 commits into from
Aug 21, 2020

Conversation

maxbischoff
Copy link
Member

@maxbischoff maxbischoff commented Aug 20, 2020

fixes: #113
fixes: #101

@maxbischoff maxbischoff marked this pull request as ready for review August 20, 2020 16:11
Copy link
Contributor

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one thin: make lint happy and rebase to perform the e2e tests.

@maxbischoff maxbischoff requested a review from johscheuer August 20, 2020 19:31
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #122 into master will increase coverage by 0.19%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   39.02%   39.21%   +0.19%     
==========================================
  Files          11       11              
  Lines        1330     1321       -9     
  Branches      264      264              
==========================================
- Hits          519      518       -1     
+ Misses        763      755       -8     
  Partials       48       48              
Impacted Files Coverage Δ
src/illuminatio/illuminatio_runner.py 28.57% <0.00%> (+0.65%) ⬆️
src/illuminatio/k8s_util.py 21.73% <0.00%> (ø)
src/illuminatio/test_orchestrator.py 24.17% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1ab409...ede4883. Read the comment docs.

Copy link
Contributor

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@johscheuer johscheuer merged commit 521823f into inovex:master Aug 21, 2020
@maxbischoff maxbischoff mentioned this pull request Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support IPv6 illuminatio should use cluster ip instead of DNS entry
2 participants