Skip to content
This repository was archived by the owner on Jul 5, 2023. It is now read-only.

Fix test generation failing for NetworkPolicy ports without port value #120

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Fix test generation failing for NetworkPolicy ports without port value #120

merged 2 commits into from
Aug 20, 2020

Conversation

maxbischoff
Copy link
Member

@maxbischoff maxbischoff commented Aug 20, 2020

Closes #102

@maxbischoff maxbischoff requested a review from johscheuer August 20, 2020 13:32
@maxbischoff maxbischoff changed the title Fix #102 Fix test generation failing for NetworkPolicy ports without port value Aug 20, 2020
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #120 into master will increase coverage by 17.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #120       +/-   ##
===========================================
+ Coverage   21.98%   39.02%   +17.03%     
===========================================
  Files           9       11        +2     
  Lines        1087     1330      +243     
  Branches      224      264       +40     
===========================================
+ Hits          239      519      +280     
+ Misses        831      763       -68     
- Partials       17       48       +31     
Impacted Files Coverage Δ
src/illuminatio/test_case.py 80.95% <100.00%> (+44.02%) ⬆️
src/illuminatio/k8s_util.py 21.73% <0.00%> (ø)
src/illuminatio/illuminatio.py 0.00% <0.00%> (ø)
src/illuminatio/cleaner.py 0.00% <0.00%> (ø)
src/illuminatio/illuminatio_runner.py 27.91% <0.00%> (+9.13%) ⬆️
src/illuminatio/test_orchestrator.py 24.10% <0.00%> (+12.79%) ⬆️
src/illuminatio/rule.py 57.33% <0.00%> (+25.33%) ⬆️
src/illuminatio/host.py 64.39% <0.00%> (+29.54%) ⬆️
src/illuminatio/util.py 90.47% <0.00%> (+41.26%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d0ef48...3a1b422. Read the comment docs.

Copy link
Contributor

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@johscheuer johscheuer merged commit 236e740 into inovex:master Aug 20, 2020
@maxbischoff maxbischoff deleted the fix-crash-on-empty-port-in-networkpolicy branch August 20, 2020 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

illuminatio should support NetworkPolicies with empty ports
2 participants