This repository was archived by the owner on Jul 5, 2023. It is now read-only.
Support all allowed Kubernetes labels #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When discovering test cases pytest also runs the function called in parametrize, causing e2e runs to fail due to missing nmap dependency. This commit refactors the runner tests to only initilize the nmap PortScanner when the test cases are actually run.
johscheuer
suggested changes
Aug 18, 2020
johscheuer
suggested changes
Aug 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
==========================================
+ Coverage 37.67% 38.88% +1.20%
==========================================
Files 11 11
Lines 1327 1332 +5
Branches 265 265
==========================================
+ Hits 500 518 +18
+ Misses 775 764 -11
+ Partials 52 50 -2
Continue to review full report at Codecov.
|
johscheuer
reviewed
Aug 18, 2020
johscheuer
reviewed
Aug 18, 2020
johscheuer
approved these changes
Aug 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #104