Skip to content
This repository was archived by the owner on Jul 5, 2023. It is now read-only.

Cleanup test generator tests #116

Merged
merged 3 commits into from
Aug 18, 2020
Merged

Cleanup test generator tests #116

merged 3 commits into from
Aug 18, 2020

Conversation

maxbischoff
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #116 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   37.67%   37.82%   +0.15%     
==========================================
  Files          11       11              
  Lines        1327     1327              
  Branches      265      265              
==========================================
+ Hits          500      502       +2     
+ Misses        775      774       -1     
+ Partials       52       51       -1     
Impacted Files Coverage Δ
src/illuminatio/rule.py 56.00% <0.00%> (+2.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d571fe1...26d226b. Read the comment docs.

@maxbischoff maxbischoff requested a review from johscheuer August 18, 2020 11:46
Copy link
Contributor

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one small nit.

@maxbischoff maxbischoff requested a review from johscheuer August 18, 2020 13:08
Copy link
Contributor

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash your commits.

@maxbischoff maxbischoff merged commit c0ec2c5 into inovex:master Aug 18, 2020
@maxbischoff maxbischoff deleted the cleanup-test-generator-tests branch August 18, 2020 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants