-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
I will add some additional unit tests for the |
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
===========================================
- Coverage 48.22% 37.67% -10.55%
===========================================
Files 8 11 +3
Lines 846 1327 +481
Branches 191 265 +74
===========================================
+ Hits 408 500 +92
- Misses 389 775 +386
- Partials 49 52 +3
Continue to review full report at Codecov.
|
a5c5b90
to
462bb3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks, otherwise LGTM!
Thanks for your contribution.
Add test for nmap result parse
0bdd29f
to
cf0f77a
Compare
The code coverage decrease is the result of some ignored files previously |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more nitpick, otherwise LGTM
Fixes: #49