Skip to content
This repository was archived by the owner on Jul 5, 2023. It is now read-only.

Make use of python-nmap #109

Merged
merged 3 commits into from
Aug 12, 2020
Merged

Conversation

johscheuer
Copy link
Contributor

Fixes: #49

@johscheuer
Copy link
Contributor Author

I will add some additional unit tests for the python nmap setup.

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #109 into master will decrease coverage by 10.54%.
The diff coverage is 39.02%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #109       +/-   ##
===========================================
- Coverage   48.22%   37.67%   -10.55%     
===========================================
  Files           8       11        +3     
  Lines         846     1327      +481     
  Branches      191      265       +74     
===========================================
+ Hits          408      500       +92     
- Misses        389      775      +386     
- Partials       49       52        +3     
Impacted Files Coverage Δ
src/illuminatio/illuminatio_runner.py 27.91% <39.02%> (ø)
src/illuminatio/cleaner.py 0.00% <0.00%> (ø)
src/illuminatio/illuminatio.py 0.00% <0.00%> (ø)
src/illuminatio/test_case.py 78.46% <0.00%> (+0.68%) ⬆️
src/illuminatio/util.py 90.47% <0.00%> (+5.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a67aade...072b11c. Read the comment docs.

@johscheuer johscheuer marked this pull request as ready for review August 4, 2020 15:52
@johscheuer johscheuer requested a review from maxbischoff August 4, 2020 15:52
Copy link
Member

@maxbischoff maxbischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks, otherwise LGTM!

Thanks for your contribution.

@johscheuer johscheuer mentioned this pull request Aug 6, 2020
Add test for nmap result parse
@johscheuer johscheuer mentioned this pull request Aug 6, 2020
@johscheuer johscheuer requested a review from maxbischoff August 6, 2020 07:38
@johscheuer
Copy link
Contributor Author

The code coverage decrease is the result of some ignored files previously

Copy link
Member

@maxbischoff maxbischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more nitpick, otherwise LGTM

@maxbischoff maxbischoff merged commit 9deef02 into inovex:master Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate the use of python-nmap
2 participants