Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube/Overlay buttons): add patch option WiderButtonsSpace #87

Merged
merged 3 commits into from
Sep 30, 2024
+18 −3
Merged

feat(YouTube/Overlay buttons): add patch option WiderButtonsSpace #87

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d614d21
add patch option "WiderButtonsSpace"
MondayNitro Sep 30, 2024
9baa5c4
add patch option "WiderButtonsSpace"
MondayNitro Sep 30, 2024
fdcdb7f
fix: fix build errors and remove duplicate resources
inotia00 Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions src/main/kotlin/app/revanced/patches/youtube/player/overlaybuttons/OverlayButtonsPatch.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,15 @@ object OverlayButtonsPatch : BaseResourcePatch(
required = true
)

// Option to choose wider between-buttons space
private val WiderButtonsSpace by booleanPatchOption(
key = "WiderButtonsSpace",
default = false,
title = "Wider between-buttons space",
description = "Prevent adjacent button presses by increasing the horizontal spacing between buttons.",
required = true
)

// Option to change top buttons
private val ChangeTopButtons by booleanPatchOption(
key = "ChangeTopButtons",
Expand Down Expand Up @@ -203,16 +212,22 @@ object OverlayButtonsPatch : BaseResourcePatch(
"@id/timestamps_container" to "14.0dip"
)

val widerButtonsSpace = WiderButtonsSpace == true
val layoutHeightWidth = if (widerButtonsSpace)
"56.0dip"
else
"48.0dip"

if (isButton) {
node.setAttribute("android:layout_marginBottom", marginBottom)
node.setAttribute("android:paddingLeft", "0.0dip")
node.setAttribute("android:paddingRight", "0.0dip")
node.setAttribute("android:paddingBottom", "22.0dip")
if (heightIsNotZero && widthIsNotZero) {
node.setAttribute("android:layout_height", "48.0dip")
node.setAttribute("android:layout_width", "48.0dip")
node.setAttribute("android:layout_height", layoutHeightWidth)
node.setAttribute("android:layout_width", layoutHeightWidth)
}
} else if (timBarItem.containsKey(id)) {
} else if (!widerButtonsSpace && timBarItem.containsKey(id)) {
node.setAttribute("android:layout_marginBottom", marginBottom)
node.setAttribute("android:paddingBottom", timBarItem.getValue(id))
}
Expand Down