feat(YouTube/Spoof app version): remove obsolete 19.13.37 spoof target …

…inotia00/ReVanced_Extended#2477
inotia00 · Nov 8, 2024 · 173494d · 173494d
1 parent 47fd194
commit 173494d
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 23 deletions.
diff --git a/src/main/kotlin/app/revanced/patches/youtube/general/spoofappversion/SpoofAppVersionPatch.kt b/src/main/kotlin/app/revanced/patches/youtube/general/spoofappversion/SpoofAppVersionPatch.kt
@@ -1,13 +1,9 @@
 package app.revanced.patches.youtube.general.spoofappversion
 
 import app.revanced.patcher.data.ResourceContext
-import app.revanced.patcher.extensions.InstructionExtensions.replaceInstruction
 import app.revanced.patches.youtube.utils.compatibility.Constants.COMPATIBLE_PACKAGE
-import app.revanced.patches.youtube.utils.integrations.Constants.PATCH_STATUS_CLASS_DESCRIPTOR
-import app.revanced.patches.youtube.utils.settings.SettingsBytecodePatch
 import app.revanced.patches.youtube.utils.settings.SettingsPatch
 import app.revanced.util.appendAppVersion
-import app.revanced.util.findMethodOrThrow
 import app.revanced.util.patch.BaseResourcePatch
 
 @Suppress("unused")
@@ -17,7 +13,6 @@ object SpoofAppVersionPatch : BaseResourcePatch(
             "This can be used to restore old UI elements and features.",
     dependencies = setOf(
         SettingsPatch::class,
-        SettingsBytecodePatch::class,
         SpoofAppVersionBytecodePatch::class
     ),
     compatiblePackages = COMPATIBLE_PACKAGE
@@ -30,18 +25,6 @@ object SpoofAppVersionPatch : BaseResourcePatch(
                 context.appendAppVersion("18.38.45")
                 if (SettingsPatch.upward1849) {
                     context.appendAppVersion("18.48.39")
-                    if (SettingsPatch.upward1915) {
-                        context.appendAppVersion("19.13.37")
-
-                        SettingsBytecodePatch.contexts.findMethodOrThrow(
-                            PATCH_STATUS_CLASS_DESCRIPTOR
-                        ) {
-                            name == "SpoofAppVersionDefaultString"
-                        }.replaceInstruction(
-                            0,
-                            "const-string v0, \"19.13.37\""
-                        )
-                    }
                 }
             }
         }

diff --git a/src/main/resources/youtube/settings/host/values/strings.xml b/src/main/resources/youtube/settings/host/values/strings.xml
@@ -13,11 +13,6 @@
     <string name="revanced_extended_confirm_user_dialog_title">Do you wish to proceed?</string>
     <string name="revanced_extended_restart_first_run">Restart to load the layout normally</string>
     <string name="revanced_extended_restart_message">Refresh and restart</string>
-    <string name="revanced_extended_restart_first_run_rolling_number">"There is a YouTube server-side bug that causes rolling number text such as likes, views, and upload dates to be hidden for some users.
-
-A temporary workaround for this issue is to spoof the app version to 19.13.37.
-
-Do you want to spoof the app version before restarting the app?"</string>
     <string name="revanced_playback_speed_normal">Normal</string>
 
     <string name="revanced_external_downloader_package_name_video_title">Video downloader package name</string>
@@ -395,7 +390,6 @@ If later turned off, it is recommended to clear the app data to prevent UI bugs.
     <string name="revanced_spoof_app_version_target_entry_18_33_40">18.33.40 - Restore old Shorts action bar</string>
     <string name="revanced_spoof_app_version_target_entry_18_38_45">18.38.45 - Restore old default video quality behavior</string>
     <string name="revanced_spoof_app_version_target_entry_18_48_39">18.48.39 - Disable views and likes from being updated in real time</string>
-    <string name="revanced_spoof_app_version_target_entry_19_13_37">19.13.37 - Restore old style Rolling number animations</string>
 
     <!-- PreferenceScreen: General, PreferenceCategory: General, PreferenceScreen: Account menu -->
     <string name="revanced_preference_screen_account_menu_title">Account menu</string>