-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add file and folder selection functionality #6
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
i noticed that, I didn't have time to look deeply, so I removed the changes locally that were based on the modified patcher. glad you fixed that, I have in mind how to solve the first of the two still unsolved problems, tomorrow I'll do that :) |
i'm fairly certain that, because of the various processes untied during the patching phase, the minimum level of permissions to access files is this edit: i can't think of a better name for this PR, change it if you need to |
it's worth adding that the permissions request should only be needed on Android 10+ (need other testing), so it could only be asked if the device is in that category |
ready for review @inotia00 :) |
Thanks |
Thanks to you as well |
@inotia00 you reverted this in the latest version |
all the managers have broken the "Select file path" and "Select folder path" when editing the patch options, also if you put a valid path there it throws a PathNotFoundException
i made this as draft because i still need to find the lowest permissions that make the feature work. right now i managed to patch by selecting the folder from the UI and get the right permissions to read all the needed files. things left to make:
ref: flutter/flutter#40498 (comment)