Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes refactor #35

Merged
merged 4 commits into from
May 15, 2023
Merged

Footnotes refactor #35

merged 4 commits into from
May 15, 2023

Conversation

hgodinho
Copy link
Contributor

@hgodinho hgodinho commented May 13, 2023

Hello there!

Here is my suggest to support footnotes. Still has limitations in inline footnotes, as mdast is returning a text type and not a footnote type.

I also added a .editorconfig to avoid messing up with your code, as my vscode is configured to use tab_width = 4.

@hgodinho hgodinho mentioned this pull request May 14, 2023
@inokawa
Copy link
Owner

inokawa commented May 14, 2023

@hgodinho
Could you update snapshot of test for footnotes?
Thank you for your PR!

@hgodinho
Copy link
Contributor Author

never used snapshot before, nice discovery!

@hgodinho
Copy link
Contributor Author

in my machine the problem is in the latex spec, that goes beyond my knowledge =/

Copy link
Owner

@inokawa inokawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@inokawa inokawa merged commit 1cf52c1 into inokawa:main May 15, 2023
@inokawa inokawa mentioned this pull request May 15, 2023
@Fenugreek
Copy link

In my .md file, I used the syntax for footnotes [^1] and [^1]: as in the mdast README1.
Footnotes do not appear in the generated .docx.
I am using version 0.1.6.
Is the syntax incorrect? Where can I look this up? Interestingly, that syntax works here for this comment.
Thanks.

Footnotes

  1. https://github.com/syntax-tree/mdast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants