Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/6174 instance query [DRAFT] #6190

Closed
wants to merge 74 commits into from
Closed

Conversation

matborowczyk
Copy link
Collaborator

@matborowczyk matborowczyk commented Feb 7, 2025

Description

It's the final PR that will merge service and service instance queries replacement + fixes to the 8th scenario to fix some flake that recently occured

closes #6147

Self Check:

Strike through any lines that are not applicable (~~line~~) then check the box

  • Attached issue to pull request
  • Changelog entry
  • Code is clear and sufficiently documented
  • Sufficient test cases (reproduces the bug/tests the requested feature)
  • Correct, in line with design
  • End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

@@ -425,13 +425,14 @@ if (Cypress.env("edition") === "iso") {

//Drag extra_embedded onto canvas and assert that is highlighted as loose element
cy.get('[aria-labelledby="bodyTwo_extra_embedded"]')
.trigger("mouseover")
.trigger("mousedown")
.trigger("mouseover", { force: true }) // sometimes cypress doesn't trigger the event as text in that element is in front of the component
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we aren't targetting the right element, causing the confusion for cypress somehow. I'm not a fan of using the force; true, but I'll let it through since this is a really big PR. Can you make a ticket for this to look into it better?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matborowczyk matborowczyk marked this pull request as ready for review February 13, 2025 06:33
@matborowczyk matborowczyk added the merge-tool-ready This ticket is ready to be merged in label Feb 13, 2025
@inmantaci
Copy link
Contributor

Processing this pull request

inmantaci pushed a commit that referenced this pull request Feb 13, 2025
…h replacement of v1 queries with react-query implementation (Issue #6178, PR #6190)

# Description

It's the final PR that will merge service and service instance queries replacement + fixes to the 8th scenario to fix some flake that recently occured

closes #6147

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [ ] Attached issue to pull request
- [ ] Changelog entry
- [ ] Code is clear and sufficiently documented
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
@inmantaci
Copy link
Contributor

Merged into branches master, iso8 in 2e2c2de

@inmantaci inmantaci closed this Feb 13, 2025
@inmantaci inmantaci deleted the issue/6174-instance-query branch February 13, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-tool-ready This ticket is ready to be merged in
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants