-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/6174 instance query [DRAFT] #6190
Conversation
…rvice-queries-replacement
…a/web-console into issue/service-queries-replacement
…74-instance-queries
…78-query-duplicates
4/4 PR - Test fixes
@@ -425,13 +425,14 @@ if (Cypress.env("edition") === "iso") { | |||
|
|||
//Drag extra_embedded onto canvas and assert that is highlighted as loose element | |||
cy.get('[aria-labelledby="bodyTwo_extra_embedded"]') | |||
.trigger("mouseover") | |||
.trigger("mousedown") | |||
.trigger("mouseover", { force: true }) // sometimes cypress doesn't trigger the event as text in that element is in front of the component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we aren't targetting the right element, causing the confusion for cypress somehow. I'm not a fan of using the force; true, but I'll let it through since this is a really big PR. Can you make a ticket for this to look into it better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Processing this pull request |
…h replacement of v1 queries with react-query implementation (Issue #6178, PR #6190) # Description It's the final PR that will merge service and service instance queries replacement + fixes to the 8th scenario to fix some flake that recently occured closes #6147 # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [ ] Changelog entry - [ ] Code is clear and sufficiently documented - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
Merged into branches master, iso8 in 2e2c2de |
Description
It's the final PR that will merge service and service instance queries replacement + fixes to the 8th scenario to fix some flake that recently occured
closes #6147
Self Check:
Strike through any lines that are not applicable (
~~line~~
) then check the box