Wait for elements to be valid before attempting to type in them #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,6 +35,9 @@ - (void)setText:(NSString *)text { | |||
|
|
|||
| - (void)setText:(NSString *)text withKeyboard:(id<SLKeyboard>)keyboard | |||
| { | |||
| // Need to make sure the element is visible first, because hasKeyboardFocus is a one-shot check | |||
| [self waitUntilValidWithTimeout:[SLElement defaultTimeout]]; | |||
|
|
|||
| // Tap to show the keyboard (if the field doesn't already have keyboard focus, | |||
| // because in that case a real user would probably not tap again before typing) | |||
| if (![self hasKeyboardFocus]) { | |||
There was a problem hiding this comment.
I think it would be simpler just to amend this line to read if (![self isValid] || ![self hasKeyboardFocus]) {…. Then we can use tap to wait for validity.
|
Good catch, @justinseanmartin-- |
wearhere
added a commit
that referenced
this pull request
Jul 9, 2014
…t-before-typing Wait for elements to be valid before attempting to type in them
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for elements to be valid before attempting to type in them. I was finding that sometimes the "type" would be failing because an alert window was still the keyWindow when [self hasKeyboardFocus] would attempt to generate an accessibilityPath.