Update subliminal-test to take advantage of instruments 5.1.
#181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 17, 2014 03:38
It's not technically correct to say that 7.0 is no longer supported _at all_, but we remove it from the list because we don't plan to test against it in CI. We remove 5.1 because Travis no longer supports 5.1.
…pe. (resolves #143) This capability, added in Xcode 5.1, obviates the need to enable/disable SDKs to force `instruments` to use a particular SDK for testing (http://openradar.appspot.com/radar?id=3107401) and the need to specify the `TARGETED_DEVICE_FAMILY` argument to force `instruments` to use a particular device family for testing (http://openradar.appspot.com/13607967). The first components of the configurations respected by the `-w` flag (the device types) are the same as the items listed in the iOS Simulator's "Hardware -> Device" menu, so `subliminal-test` remains backwards-compatible, despite its documentation changing. Some references to iOS 5.1 have been updated in preparation for our eventual dropping of 5.1 support (though we still do support it currently).
…est`. (refs #176) `instruments` may (and should) be "pre-authorized" using the instructions at https://github.com/inkling/Subliminal/wiki/Continuous-Integration#faq.
Travis initializes submodules for us as described here: http://docs.travis-ci.com/user/build-configuration/#Git-Submodules
It's not (yet?) installed on the new 10.9 boxes.
appledoc 2.1 uses GC and so cannot be compiled using Xcode 5.1, so we download a pre-built version from the `gh-pages` branch and manually install it. The version was pre-built following the instructions [here][1] using Xcode 5.0.2 and the `appledoc21` formula. I thought that maybe we could install the resulting bottle [directly][2] but for some reason that fails. [1] https://github.com/Homebrew/homebrew/wiki/Bottles [2] https://github.com/Homebrew/homebrew/wiki/Bottles#local-bottle-usage
`xctool` 0.1.14 will fail to run Subliminal's unit tests. Travis is supposed to have 0.1.15 installed--see travis-ci/travis-ci#2051 (comment).
ahaneyinkling
added a commit
that referenced
this pull request
Apr 19, 2014
Update `subliminal-test` to take advantage of `instruments` 5.1.
MaxGabriel
added a commit
to MaxGabriel/Subliminal
that referenced
this pull request
Apr 19, 2014
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #143--we now use
instruments5.1's ability to select the device type and SDK, and ask the user to pre-authorize the test machine rather than provide their login password tosubliminal-test.The wiki has already been updated in anticipation of these changes.