Skip to content

Commit

Permalink
Fix error checking around instruments failing to launch.
Browse files Browse the repository at this point in the history
By assigning to `RESULT_LOG` after launching instruments,
we failed to check instruments' exit status.
  • Loading branch information
Jeff Wear committed Aug 14, 2013
1 parent c95d77a commit 3aae613
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Supporting Files/CI/subliminal-test
Original file line number Diff line number Diff line change
Expand Up @@ -500,8 +500,8 @@ launch_instruments () {
-e UIARESULTSPATH "$RESULTS_DIR"
}

launch_instruments
RESULT_LOG="$RESULTS_DIR/Run 1/Automation Results.plist"
launch_instruments
if [ $? -ne 0 ] && [ ! -e "$RESULT_LOG" ]; then
# Under poorly understood circumstances, in certain CI environments like Travis,
# instruments may fail to launch what otherwise appears to be a perfectly good app
Expand Down

0 comments on commit 3aae613

Please sign in to comment.