return error ack when the packet is wasm routed but has error at deco…

…ding
initia-labs · Mar 3, 2025 · 7c141ae · 7c141ae
1 parent 019817f
commit 7c141ae
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/ibc-hooks/receive.go b/app/ibc-hooks/receive.go
@@ -27,7 +27,7 @@ func (h WasmHooks) onRecvIcs20Packet(
 	data transfertypes.FungibleTokenPacketData,
 ) ibcexported.Acknowledgement {
 	isWasmRouted, hookData, err := validateAndParseMemo(data.GetMemo())
-	if !isWasmRouted || hookData.Message == nil {
+	if !isWasmRouted || (err == nil && hookData.Message == nil) {
 		return im.App.OnRecvPacket(ctx, packet, relayer)
 	} else if err != nil {
 		return newEmitErrorAcknowledgement(err)
@@ -91,7 +91,7 @@ func (h WasmHooks) onRecvIcs721Packet(
 	data nfttransfertypes.NonFungibleTokenPacketData,
 ) ibcexported.Acknowledgement {
 	isWasmRouted, hookData, err := validateAndParseMemo(data.GetMemo())
-	if !isWasmRouted || hookData.Message == nil {
+	if !isWasmRouted || (err == nil && hookData.Message == nil) {
 		return im.App.OnRecvPacket(ctx, packet, relayer)
 	} else if err != nil {
 		return newEmitErrorAcknowledgement(err)