-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove FIXME and Update broken default verifier URL #361
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThe change updates the verification endpoint in the application. Specifically, the constant Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -26,7 +26,7 @@ const ( | |||
flagVerifierURL = "verifier-url" | |||
) | |||
|
|||
const defaultVerifierURL = "https://api.initia.tech/contracts/verify" // FIXME: set to real url | |||
const defaultVerifierURL = "https://api.testnet.initia.xyz/contracts/verify" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify the Correct Verifier URL Domain.
The PR objective specifies updating the default verifier URL to https://api.testnet.initia.tech/contracts/verify
, but the modified constant currently uses https://api.testnet.initia.xyz/contracts/verify
. Please confirm the correct domain and update if necessary.
Description
This PR updates the broken default verifier URL from
https://api.initia.tech/contracts/verify
tohttps://api.testnet.initia.tech/contracts/verify
, ensuring the correct endpoint is used.Additionally, the
FIXME
comment has been removed as the issue has been resolved.Author Checklist
!
in the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...