feat: audit

.github/workflows/docker.yml

@@ -11,13 +11,6 @@ on:
       - "**.go"
       - "go.mod"
       - "go.sum"
-  pull_request:
-    branches:
-      - "main"
-    paths:
-      - "**.go"
-      - "go.mod"
-      - "go.sum"
 
 env:
   REGISTRY: ghcr.io
@@ -61,6 +54,8 @@ jobs:
           push: ${{ startsWith(github.ref, 'refs/tags') }} # push image only for tags
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}
+        env:
+          VERSION: ${{ github.ref_name }}
 
   node:
     if: ${{ startsWith(github.ref, 'refs/tags/') }}

x/distribution/keeper/allocation.go

@@ -80,7 +80,7 @@ func (k Keeper) AllocateTokens(ctx context.Context, totalPreviousPower int64, bo
 
 	// allocate rewards proportionally to reward power
 	for _, rewardWeight := range rewardWeights {
-		poolFraction := rewardWeight.Weight.Quo(weightsSum)
+		poolFraction := rewardWeight.Weight.QuoTruncate(weightsSum)
 		poolReward := feesCollected.MulDecTruncate(voteMultiplier).MulDecTruncate(poolFraction)
 
 		poolDenom := rewardWeight.Denom

x/distribution/keeper/genesis.go

@@ -122,7 +122,14 @@
 	if balances.IsZero() {
 		k.authKeeper.SetModuleAccount(ctx, moduleAcc)
 	}
-	if !balances.Equal(moduleHoldingsInt) {
+
+	// It is hard to block fungible asset transfer from move side,
+	// so we can't guarantee the ModuleAccount is always equal to the sum
+	// of the distribution rewards and community pool. Instead, we decide to check
+	// if the ModuleAccount balance is greater than or equal to the sum of
+	// the distribution rewards and community pool.
+	broken := !balances.IsAllGTE(moduleHoldingsInt)
+	if broken {
 		panic(fmt.Sprintf("distribution module balance does not match the module holdings: %s <-> %s", balances, moduleHoldingsInt))
 	}
 }

x/evidence/keeper/msg_server.go

@@ -3,8 +3,11 @@
 import (
 	"context"
 
+	"cosmossdk.io/errors"
 	"cosmossdk.io/x/evidence/types"
+
 	sdk "github.com/cosmos/cosmos-sdk/types"
+	sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
 )
 
 type msgServer struct {
@@ -21,9 +24,20 @@
 
 // SubmitEvidence implements the MsgServer.SubmitEvidence method.
 func (ms msgServer) SubmitEvidence(goCtx context.Context, msg *types.MsgSubmitEvidence) (*types.MsgSubmitEvidenceResponse, error) {
-	ctx := sdk.UnwrapSDKContext(goCtx)
+	if _, err := ms.addressCodec.StringToBytes(msg.Submitter); err != nil {
+		return nil, sdkerrors.ErrInvalidAddress.Wrapf("invalid submitter address: %s", err)
+	}
 
 	evidence := msg.GetEvidence()
+	if evidence == nil {
+		return nil, errors.Wrap(types.ErrInvalidEvidence, "missing evidence")
+	}
+
+	if err := evidence.ValidateBasic(); err != nil {
+		return nil, errors.Wrapf(types.ErrInvalidEvidence, "failed basic validation: %s", err)
+	}
+
+	ctx := sdk.UnwrapSDKContext(goCtx)
 	if err := ms.Keeper.SubmitEvidence(ctx, evidence); err != nil {
 		return nil, err
 	}

x/ibc-hooks/move-hooks/receive.go

@@ -22,7 +22,7 @@ func (h MoveHooks) onRecvIcs20Packet(
 	data transfertypes.FungibleTokenPacketData,
 ) ibcexported.Acknowledgement {
 	isMoveRouted, hookData, err := validateAndParseMemo(data.GetMemo())
-	if !isMoveRouted || hookData.Message == nil {
+	if !isMoveRouted || (err == nil && hookData.Message == nil) {
 		return im.App.OnRecvPacket(ctx, packet, relayer)
 	} else if err != nil {
 		return newEmitErrorAcknowledgement(err)
@@ -74,7 +74,7 @@ func (h MoveHooks) onRecvIcs721Packet(
 	data nfttransfertypes.NonFungibleTokenPacketData,
 ) ibcexported.Acknowledgement {
 	isMoveRouted, hookData, err := validateAndParseMemo(data.GetMemo())
-	if !isMoveRouted || hookData.Message == nil {
+	if !isMoveRouted || (err == nil && hookData.Message == nil) {
 		return im.App.OnRecvPacket(ctx, packet, relayer)
 	} else if err != nil {
 		return newEmitErrorAcknowledgement(err)

x/intertx/keeper/msg_server.go

@@ -37,7 +37,15 @@
 	icaMsg := icacontrollertypes.NewMsgRegisterInterchainAccount(msg.ConnectionId, msg.Owner, msg.Version)
 	icaMsg.Ordering = msg.Ordering
 
-	if _, err := k.icaControllerMsgServer.RegisterInterchainAccount(ctx, icaMsg); err != nil {
+	// validate the icaMsg
+	err := icaMsg.ValidateBasic()
+	if err != nil {
+		return nil, err
+	}
+
+	// send the icaMsg to the ica controller
+	_, err = k.icaControllerMsgServer.RegisterInterchainAccount(ctx, icaMsg)
+	if err != nil {
 		return nil, err
 	}
 
@@ -64,6 +72,14 @@
 
 	relativeTimeoutTimestamp := uint64((time.Minute * 5).Nanoseconds())
 	icaMsg := icacontrollertypes.NewMsgSendTx(msg.Owner, msg.ConnectionId, uint64(relativeTimeoutTimestamp), packetData)
+
+	// validate the icaMsg
+	err = icaMsg.ValidateBasic()
+	if err != nil {
+		return nil, err
+	}
+
+	// send the icaMsg to the ica controller
 	_, err = k.icaControllerMsgServer.SendTx(ctx, icaMsg)
 	if err != nil {
 		return nil, err

x/move/keeper/genesis.go

@@ -68,7 +68,7 @@ func (k Keeper) Initialize(
 		}
 	}
 
-	return k.handleExecuteResponse(sdkCtx, sdkCtx.GasMeter(), execRes)
+	return nil
 }
 
 // InitGenesis sets supply information for genesis.

x/move/keeper/handler.go

@@ -391,7 +391,13 @@
 	ctx, commit := parentCtx.CacheContext()
 	defer func() {
 		if r := recover(); r != nil {
-			err = fmt.Errorf("panic: %v", r)
+			switch r.(type) {
+			case storetypes.ErrorOutOfGas:
+				// propagate out of gas error
+				panic(r)
+			default:
+				err = fmt.Errorf("panic: %v", r)
+			}
 		}
 
 		success := err == nil
@@ -580,28 +586,25 @@
 		return vmtypes.ViewOutput{}, 0, err
 	}
 
-	executionCounter, err := k.ExecutionCounter.Next(ctx)
+	ac := types.NextAccountNumber(ctx, k.authKeeper)
+	ec, err := k.ExecutionCounter.Next(ctx)
 	if err != nil {
 		return vmtypes.ViewOutput{}, 0, err
 	}
 
-	api := NewApi(k, ctx)
-	env := types.NewEnv(
-		ctx,
-		types.NextAccountNumber(ctx, k.authKeeper),
-		executionCounter,
-	)
-
 	sdkCtx := sdk.UnwrapSDKContext(ctx)
 	gasMeter := sdkCtx.GasMeter()
 	gasForRuntime := k.computeGasForRuntime(ctx, gasMeter)
 
+	// delegate gas metering to move vm
+	sdkCtx = sdkCtx.WithGasMeter(storetypes.NewInfiniteGasMeter())
+
 	gasBalance := gasForRuntime
 	viewRes, err := k.initiaMoveVM.ExecuteViewFunction(
 		&gasBalance,
-		types.NewVMStore(ctx, k.VMStore),
-		api,
-		env,
+		types.NewVMStore(sdkCtx, k.VMStore),
+		NewApi(k, sdkCtx),
+		types.NewEnv(sdkCtx, ac, ec),
 		payload,
 	)
 

x/move/types/connector.go

@@ -412,7 +412,7 @@
 	timestampBefore, timestampAfter, timestamp math.Int,
 ) (math.LegacyDec, math.LegacyDec, error) {
 	if timestampBefore.GT(timestamp) {
-		return math.LegacyZeroDec(), math.LegacyZeroDec(), ErrInvalidDexConfig
+		return weightCoinABefore, weightCoinBBefore, nil
 	}
 
 	if timestamp.GTE(timestampAfter) {