Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Dockerfile for building multiplatform clearly. #170

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

qj0r9j0vc2
Copy link
Contributor

fix for issue - Docker buildkit build for linux/amd64 failed on apple silicon machine. #169

This docker file allows you to clearly build a multi-platform image.

In this Dockerfile version, it added specific env for GOARCH.

fix for issue - Docker buildkit build for linux/amd64 failed on apple silicon machine. initia-labs#169
@qj0r9j0vc2 qj0r9j0vc2 requested a review from a team as a code owner May 18, 2024 09:12
Copy link

coderabbitai bot commented May 18, 2024

Walkthrough

Walkthrough

The Dockerfile has undergone several updates to improve architecture handling and streamline library downloads. Key changes include replacing static architecture definitions with dynamic arguments, repositioning package installations, and switching from ADD to wget for fetching libraries. Additionally, specific commands have been adjusted to utilize the new architecture variables.

Changes

File Change Summary
Dockerfile - ARG arch=x86_64 replaced with ARG TARGETARCH
- Added ARG GOARCH
- Moved RUN apk add git cmake before WORKDIR /code
- Replaced ADD ... with wget -O ... for downloading libraries
- Updated cp commands to use ${ARCH} instead of uname -m
- Modified build command to include GOARCH=${GOARCH}

In a Dockerfile so bright and keen,
Variables dance, a new routine,
From arch to TARGETARCH they glide,
While wget fetches libraries with pride.
Packages installed, before the code,
A streamlined path, a smoother road.
🎉🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (1)
Dockerfile (1)

22-32: The architecture handling using a case statement is robust. Consider removing the echo statement if it's not needed for logging or debugging.

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between a44dbac and 9d0bda4.
Files selected for processing (1)
  • Dockerfile (2 hunks)
Additional comments not posted (4)
Dockerfile (4)

5-6: Introduction of ARG TARGETARCH and ARG GOARCH is appropriate for supporting multiplatform builds.


12-12: Use of set -eux and --no-cache in the package installation command enhances transparency and ensures fresh installations.


39-39: Inclusion of GOARCH in the build command and the use of specific linker flags are correctly implemented to support the targeted architecture.


Line range hint 41-57: Setup in the final stage of the Dockerfile, including user configuration and port exposure, follows best practices.

Copy link
Member

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution!

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants