-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update Dockerfile for building multiplatform clearly. #170
Conversation
fix for issue - Docker buildkit build for linux/amd64 failed on apple silicon machine. initia-labs#169
WalkthroughWalkthroughThe Dockerfile has undergone several updates to improve architecture handling and streamline library downloads. Key changes include replacing static architecture definitions with dynamic arguments, repositioning package installations, and switching from Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
Dockerfile (1)
22-32
: The architecture handling using a case statement is robust. Consider removing the echo statement if it's not needed for logging or debugging.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- Dockerfile (2 hunks)
Additional comments not posted (4)
Dockerfile (4)
5-6
: Introduction ofARG TARGETARCH
andARG GOARCH
is appropriate for supporting multiplatform builds.
12-12
: Use ofset -eux
and--no-cache
in the package installation command enhances transparency and ensures fresh installations.
39-39
: Inclusion ofGOARCH
in the build command and the use of specific linker flags are correctly implemented to support the targeted architecture.
Line range hint
41-57
: Setup in the final stage of the Dockerfile, including user configuration and port exposure, follows best practices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contribution!
LGTM
fix for issue - Docker buildkit build for linux/amd64 failed on apple silicon machine. #169
This docker file allows you to clearly build a multi-platform image.
In this Dockerfile version, it added specific env for GOARCH.