add missing error handling (#196)

add case check in MetadataAddressFromDenom

x/distribution/keeper/delegation.go

@@ -106,6 +106,9 @@ func (k Keeper) CalculateDelegationRewards(ctx context.Context, val stakingtypes
 
 	// fetch starting info for delegation
 	startingInfo, err := k.DelegatorStartingInfos.Get(ctx, collections.Join(valAddr, delAddr))
+	if err != nil {
+		return nil, err
+	}
 
 	sdkCtx := sdk.UnwrapSDKContext(ctx)
 	if startingInfo.Height == uint64(sdkCtx.BlockHeight()) {

x/move/types/denom.go

@@ -3,6 +3,7 @@ package types
 import (
 	context "context"
 	"encoding/hex"
+	"errors"
 	"strings"
 
 	"golang.org/x/crypto/sha3"
@@ -53,7 +54,12 @@ func UserDerivedObjectAddress(source vmtypes.AccountAddress, deriveFrom vmtypes.
 // Extract metadata address from a denom
 func MetadataAddressFromDenom(denom string) (vmtypes.AccountAddress, error) {
 	if strings.HasPrefix(denom, DenomTraceDenomPrefixMove) {
-		addrBz, err := hex.DecodeString(strings.TrimPrefix(denom, DenomTraceDenomPrefixMove))
+		hexStr := strings.TrimPrefix(denom, DenomTraceDenomPrefixMove)
+		if strings.ToLower(hexStr) != hexStr {
+			return vmtypes.AccountAddress{}, errors.New("metadata address should be lowercase")
+		}
+
+		addrBz, err := hex.DecodeString(hexStr)
 		if err != nil {
 			return vmtypes.AccountAddress{}, err
 		}

x/move/types/denom_test.go

@@ -0,0 +1,20 @@
+package types_test
+
+import (
+	"testing"
+
+	"github.com/initia-labs/initia/x/move/types"
+	"github.com/stretchr/testify/require"
+)
+
+func Test_MetadataAddressFromDenom(t *testing.T) {
+	denom := "move/944f8dd8dc49f96c25fea9849f16436dcfa6d564eec802f3ef7f8b3ea85368ff"
+	addr, err := types.MetadataAddressFromDenom(denom)
+	require.NoError(t, err)
+	require.Equal(t, "0x944f8dd8dc49f96c25fea9849f16436dcfa6d564eec802f3ef7f8b3ea85368ff", addr.String())
+
+	// upper case
+	denom = "move/944f8dd8dc49f96c25fea9849f16436dcfa6d564eec802f3ef7f8b3ea85368fF"
+	_, err = types.MetadataAddressFromDenom(denom)
+	require.Error(t, err)
+}