Skip to content

Commit

Permalink
Enforce default column family options correctly
Browse files Browse the repository at this point in the history
Summary:
There are several layers of column family options values. In order:

1) Defaults defined in ColumnFamilyOptions constructor
2) Defaults set explicitly in ha_rocksdb.cc code
3) Defaults set by rocksdb_default_cf_options sysvar
4) Per-CF options specified via rocksdb_cf_options_file

The settings from (2) were omitted inadvertently. This fixes it.

fbshipit-source-id: 2680d3a
  • Loading branch information
Jonah Cohen authored and inikep committed Nov 11, 2020
1 parent 3d631e0 commit 2524af1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions storage/rocksdb/ha_rocksdb.cc
Original file line number Diff line number Diff line change
Expand Up @@ -893,6 +893,7 @@ static bool rocksdb_show_status(handlerton* hton,

void get_cf_options(const std::string &cf_name, rocksdb::ColumnFamilyOptions *opts)
{
*opts = default_cf_opts;
rocksdb_cf_options_map.Get(cf_name, opts);
}

Expand Down

0 comments on commit 2524af1

Please sign in to comment.