Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: Propose transport agnostic abstractions #904

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

xla
Copy link
Contributor

@xla xla commented Jun 13, 2021

Describes broadly a new set of abstractions to support a transport
agnostic p2p stack. Bundled together are the types and traits in
p2p::transport. Other parts like the Supervisor will land in
follow-up change-sets.

Closes #692


Rendered ADR-009
Supersedes #708

Describes broadly a new set of abstractions to support a transport
agnostic p2p stack. Bundled together are the types and traits in
`p2p::transport`. Other parts like the `Supervisor` will land in
follow-up change-sets.

Closes #692

Signed-off-by: Alexander Simmerl <[email protected]>
@xla xla self-assigned this Jun 13, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #904 (3b39509) into master (b262d0b) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #904   +/-   ##
======================================
  Coverage    70.5%   70.5%           
======================================
  Files         203     203           
  Lines       16188   16188           
======================================
+ Hits        11418   11424    +6     
+ Misses       4770    4764    -6     
Impacted Files Coverage Δ
testgen/src/header.rs 78.8% <0.0%> (+0.6%) ⬆️
testgen/src/vote.rs 84.6% <0.0%> (+0.8%) ⬆️
light-client/src/types.rs 30.9% <0.0%> (+1.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b262d0b...3b39509. Read the comment docs.

Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@thanethomson thanethomson merged commit 05da904 into master Jun 15, 2021
@thanethomson thanethomson deleted the xla/692-p2p-transport branch June 15, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p2p: design transport agnostic peer abstraction
3 participants