p2p: use async bipipe #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #841 I had to clone the original crate to introduce 4 additional methods: 1. async_pipe 2. async_pipe_buffered 3. async_bipipe 4. async_bipipe_buffered The difference is they all use unbounded `crossbeam` channel rather then `bounded(0)` which makes them async. And we need pipe to be async because of how the handshake is written currently.
|
I will see if this could be upstreamed (I doubt that, but I will try nonetheless) arcnmx/pipe-rs#10 |
If we have doubts that it will be upstream-ed should we just maintain a pipe implementation in the p2p package for our testing purposes? |
Yeah this makes sense to me 👍 |
done 👍 |
xla
reviewed
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #841
A copy of the
pipecrate (https://github.com/arcnmx/pipe-rs) is added to thetendermint-p2pcrate. I had to add a new method -async_bipipe_bufferedto make the handshake tests always pass.async_bipipe_bufferedmethod uses theunboundedchannel (rather than the blocking one) for communication - hence the prefix. Note I also removed the methods and structures frompipeclone that we're not using at the moment.Updated all relevant documentation in docsUpdated CHANGELOG.md