Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto update #528

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Proto update #528

merged 1 commit into from
Aug 21, 2020

Conversation

greg-szabo
Copy link
Member

@greg-szabo greg-szabo commented Aug 21, 2020

Proto files updated based on tendermint Go v0.34.0-rc3

  • Required for the v0.34 upgrade

  • These files were created automatically by running the proto-compiler.

  • Changelog, docs are ongoing in other issues/PRs. (Namely on the greg/aminoff branch where this is required to continue.)

  • Referenced an issue explaining the need for the change

  • Updated all relevant documentation in docs

  • Updated all code comments where relevant

  • Wrote tests

  • Updated CHANGELOG.md

@greg-szabo greg-szabo requested a review from liamsi August 21, 2020 06:04
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

@greg-szabo greg-szabo merged commit 90e71e4 into master Aug 21, 2020
@greg-szabo greg-szabo deleted the greg/proto-update branch August 21, 2020 23:17
@greg-szabo greg-szabo restored the greg/proto-update branch August 21, 2020 23:17
@greg-szabo greg-szabo deleted the greg/proto-update branch August 21, 2020 23:17
greg-szabo added a commit that referenced this pull request Aug 24, 2020
* Proto update (#528)

* Fixes after comments on deliverable by Fernando (#531)

* fixed links

* added explanation for table

Co-authored-by: Josef Widder <[email protected]>
greg-szabo added a commit that referenced this pull request Aug 24, 2020
greg-szabo added a commit that referenced this pull request Aug 25, 2020
greg-szabo added a commit that referenced this pull request Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants