Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set integration-test-latest to continue_on_error #325

Conversation

shonfeder
Copy link
Contributor

@shonfeder shonfeder commented Jun 15, 2020

Closes #304

Followup to #324

Signed-off-by: Shon Feder [email protected]

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

@shonfeder shonfeder force-pushed the continue-on-failure-of-integration-test-latest branch 2 times, most recently from c0defdf to bf47fbf Compare June 15, 2020 13:13
Shon Feder added 2 commits June 15, 2020 09:20
Closes informalsystems#304

We want to run the integration test against the latest version, but
don't want it to clutter CI with failures. Tests against the pinned
stable version still fail.

Also fixes some whitespace.

Signed-off-by: Shon Feder <[email protected]>
Also fixed previous entries, so they pointed to their originating issue
rather than the PR that implemented them, to be consistent with other
entries.
@shonfeder shonfeder force-pushed the continue-on-failure-of-integration-test-latest branch from bf47fbf to 0a9952e Compare June 15, 2020 13:20
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2020

Codecov Report

Merging #325 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #325   +/-   ##
======================================
  Coverage    30.5%   30.5%           
======================================
  Files         127     127           
  Lines        4581    4581           
  Branches     1416    1416           
======================================
  Hits         1398    1398           
  Misses       2216    2216           
  Partials      967     967           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704e244...34d8b8b. Read the comment docs.

Copy link
Contributor

@brapse brapse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brapse brapse merged commit ca22a6d into informalsystems:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPC integration tests failing on CI
3 participants