Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Clone to EventSubscription #315

Merged
merged 2 commits into from
Jun 9, 2020
Merged

add Clone to EventSubscription #315

merged 2 commits into from
Jun 9, 2020

Conversation

ancazamfir
Copy link
Contributor

As per title, need to be able to clone this.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #315 into master will decrease coverage by 0.1%.
The diff coverage is 0.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #315     +/-   ##
========================================
- Coverage    30.6%   30.5%   -0.2%     
========================================
  Files         129     127      -2     
  Lines        4869    4581    -288     
  Branches     1546    1416    -130     
========================================
- Hits         1492    1398     -94     
+ Misses       2295    2216     -79     
+ Partials     1082     967    -115     
Impacted Files Coverage Δ
tendermint/src/rpc/event_listener.rs 0.0% <0.0%> (ø)
light-client/src/contracts.rs 63.6% <0.0%> (-36.4%) ⬇️
tendermint/src/serializers/raw_commit_sig.rs 16.6% <0.0%> (-16.7%) ⬇️
light-client/src/components/verifier.rs 58.6% <0.0%> (-12.3%) ⬇️
tendermint/src/vote/power.rs 9.0% <0.0%> (-8.4%) ⬇️
light-client/src/components/scheduler.rs 44.0% <0.0%> (-7.5%) ⬇️
light-client/src/predicates.rs 72.7% <0.0%> (-5.2%) ⬇️
light-client/src/operations/commit_validator.rs 40.0% <0.0%> (-3.8%) ⬇️
tendermint/src/validator.rs 43.7% <0.0%> (-3.7%) ⬇️
tendermint/src/serializers/custom.rs 16.6% <0.0%> (-2.7%) ⬇️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af6bcb...7895716. Read the comment docs.

@liamsi liamsi merged commit 740cb66 into master Jun 9, 2020
@liamsi liamsi deleted the anca/rpc_subscribe branch June 9, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants