Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR 012: Multi-Version Support #1274

Merged
merged 11 commits into from
Mar 10, 2023
Merged

ADR 012: Multi-Version Support #1274

merged 11 commits into from
Mar 10, 2023

Conversation

mzabaluev
Copy link
Contributor

@mzabaluev mzabaluev commented Feb 28, 2023

@mzabaluev mzabaluev marked this pull request as ready for review March 1, 2023 13:06
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first-pass review, thanks for this @mzabaluev!

Please include concrete examples of how the new API is to be used.

docs/architecture/adr-012-multi-version.md Outdated Show resolved Hide resolved
docs/architecture/adr-012-multi-version.md Outdated Show resolved Hide resolved
docs/architecture/adr-012-multi-version.md Outdated Show resolved Hide resolved
docs/architecture/adr-012-multi-version.md Outdated Show resolved Hide resolved
docs/architecture/adr-012-multi-version.md Outdated Show resolved Hide resolved
docs/architecture/adr-012-multi-version.md Outdated Show resolved Hide resolved
docs/architecture/adr-012-multi-version.md Outdated Show resolved Hide resolved
The LATEST associated const has been changed to the function.
@mzabaluev
Copy link
Contributor Author

Thank you @thanethomson, I have committed your suggestions.

Please include concrete examples of how the new API is to be used.

Will do.

@mzabaluev mzabaluev force-pushed the mikhail/adr-012-multi-version branch from 092468b to bca3ad7 Compare March 6, 2023 11:39
@romac romac merged commit 12e83a7 into main Mar 10, 2023
@romac romac deleted the mikhail/adr-012-multi-version branch March 10, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants