Replace RPC ABCI types with ABCI domain types #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
…ermint::Hash Signed-off-by: Thane Thomson <[email protected]>
mzabaluev
added
rpc
breaking
domain-types
5 tasks
Does not seem to be used for anything.
First attempt, with a serialization snag in tendermint-proto.
Instead of deriving serde on raw proto types to de/serialize abci::response::DeliverTx, abci::Event, and abci::EventAttribute, derive on the domain types directly. This disentangles the serialization, now primarily used by JSON-RPC, from protobuf struct definitions which are subject to change for Tendermint Core 0.37 (in case of EventAttribute).
In tendermint-rpc, the only place where Gas newtype is still used is in the response to /broadcast_tx_commit, which is a development-only endpoint. Leave the response struct defined through tx_commit::TxResult for the time being. Define serialization of abci::response::CheckTx (currently not used) to match that of DeliverTx.
Also in tendermint, remove validator::Update which duplicates abci::types::ValidatorUpdate.
With it goes mod abci::responses.
mzabaluev
force-pushed
the
thane+mikhail/rpc-abci-domain-types
branch
from
b602e09 to
5725d4f
Compare
Codecov Report
@@ Coverage Diff @@
## main #1204 +/- ##
=======================================
+ Coverage 64.0% 64.3% +0.3%
=======================================
Files 253 244 -9
Lines 21636 21345 -291
=======================================
- Hits 13851 13736 -115
+ Misses 7785 7609 -176
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Promote this to a proper domain type.
This was the last of the ABCI helper types defined in tendermint-rpc, and with it goes the abci module.
This was referenced Nov 2, 2022
Closed
thanethomson
approved these changes
Nov 5, 2022
| /// | ||
| /// Used to inform Tendermint of changes to the validator set. | ||
| /// | ||
| /// [ABCI documentation](https://docs.tendermint.com/master/spec/abci/abci.html#validatorupdate) |
There was a problem hiding this comment.
Suggested change
| /// [ABCI documentation](https://docs.tendermint.com/master/spec/abci/abci.html#validatorupdate) | |
| /// [ABCI documentation](https://github.com/tendermint/tendermint/blob/v0.34.x/spec/abci/abci.md#validatorupdate) |
We currently do not make the spec available via the docs site, and the one from master is no longer relevant. We also keep the specification relevant to the specific Tendermint release series on each release branch, so it's easier to see diffs in the specs between major releases of Tendermint.
There was a problem hiding this comment.
I think we can probably keep this as-is for this PR, but in a follow-up PR we should update all the spec references to rather point to the v0.34.x branch of the Tendermint repo. I've created #1224 to track this.
This was referenced Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1090 and #947
Picked up from #1092 by rebasing the branch onto
main..changelog/