Execute model checkers in a temporary directory #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnbguy
reviewed
Jul 19, 2021
modelator/src/util.rs
Outdated
| for entry in WalkDir::new(dir) | ||
| .min_depth(1) | ||
| .max_depth(1) | ||
| .into_iter() |
There was a problem hiding this comment.
Do we really need walkdir for this? std::fs::read_dir should be enough, no?
There was a problem hiding this comment.
Sure! How about you refactor this to use std::fs::read_dir, right in this branch? it would be great to avoid an additional dependency, true.
There was a problem hiding this comment.
Great, looks good!
thanks:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #33 via a simple workaround, by adding the code to the
traces()function that:.tlaand.cfgfiles into itThis prevents polluting the current directory with temporary files from generating the tests, as well as from the model checkers' output.
Some tests have been written under the assumptions that are incompatible with using the temporary directories, so those have been disabled; the refactoring to be tracked in #47.
The cache has been disabled as well; this is to be tracked in #46.