Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includes libmbt in Go module source #146

Merged
merged 10 commits into from
Dec 9, 2021
Merged

Includes libmbt in Go module source #146

merged 10 commits into from
Dec 9, 2021

Conversation

rnbguy
Copy link
Member

@rnbguy rnbguy commented Dec 7, 2021

Closes: #145

Description

Following cgo docs, libmbt should be part of go module source.

go get github.com/informalsystems/modelator/go/pkg/core would be successful when this PR is merge.

Until then, go get github.com/informalsystems/modelator/go/pkg/core@9935d79 should work as a fix.


For contributor use:

  • If applicable, unit tests are written and added to CI. Current CI takes care of it.
  • Ran go fmt, cargo fmt and etc. (or had formatting run automatically on all files edited)
  • Updated relevant documentation (docs/) and code comments.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Re-reviewed Files changed in the Github PR explorer.
  • Added a changelog entry, using unclog.

@rnbguy rnbguy self-assigned this Dec 7, 2021
@rnbguy rnbguy added the bug Something isn't working label Dec 7, 2021
@rnbguy rnbguy added this to the 12.2021 milestone Dec 7, 2021
@rnbguy
Copy link
Member Author

rnbguy commented Dec 7, 2021

This includes mbt library for x86_64 architecture only. It supports following targets

  • linux-gnu
  • darwin
  • windows-gnu

@rnbguy rnbguy force-pushed the rnbguy/go/link-libmbt branch 4 times, most recently from 7b3414c to 3074799 Compare December 8, 2021 23:03
@rnbguy rnbguy force-pushed the rnbguy/go/link-libmbt branch 2 times, most recently from e633e43 to 3579d4b Compare December 8, 2021 23:54
@rnbguy rnbguy force-pushed the rnbguy/go/link-libmbt branch 9 times, most recently from aeeed06 to 1bd5d87 Compare December 9, 2021 01:22
@rnbguy rnbguy force-pushed the rnbguy/go/link-libmbt branch from 1bd5d87 to 72a907f Compare December 9, 2021 01:26
@rnbguy rnbguy marked this pull request as ready for review December 9, 2021 01:37
@rnbguy rnbguy merged commit 9a8ebd6 into main Dec 9, 2021
@rnbguy rnbguy mentioned this pull request Dec 9, 2021
@danwt danwt deleted the rnbguy/go/link-libmbt branch January 18, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Go version is unusable as Go module
1 participant