Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store jars in user specific directory #137

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Conversation

rnbguy
Copy link
Member

@rnbguy rnbguy commented Nov 30, 2021

Closes: #136

Description

Use a user specific directory to store jar files of the model checkers and tools, so that they are not downloaded multiple time when switching work directory.

We use ProjectDirs::from("systems", "Informal", "modelator")?.data_dir() from directories.


For contributor use:

  • If applicable, unit tests are written and added to CI. (N.A. Old tests takes care of this change)
  • Ran go fmt, cargo fmt and etc. (or had formatting run automatically on all files edited)
  • Updated relevant documentation (docs/) and code comments. (N.A. Doesn't change any API)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Re-reviewed Files changed in the Github PR explorer.
  • Added a changelog entry, using unclog.

@rnbguy rnbguy self-assigned this Nov 30, 2021
@rnbguy rnbguy added the enhancement New (user-facing) feature or request label Nov 30, 2021
@rnbguy rnbguy added this to the 12.2021 milestone Nov 30, 2021
@rnbguy rnbguy changed the title use user specific directory Store jars in user specific directory Nov 30, 2021
Copy link
Contributor

@andrey-kuprianov andrey-kuprianov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@rnbguy rnbguy merged commit 92c9faa into main Dec 2, 2021
@rnbguy rnbguy mentioned this pull request Dec 9, 2021
@danwt danwt deleted the rnbguy/rust/jar-directory branch January 18, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New (user-facing) feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST] Use one global directory to store jars
2 participants