Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for redundant relays and treat them as noops (although an event must be emitted) in AcknowledgePacket and timeoutOnClose #213

Closed
Tracked by #554
plafer opened this issue Nov 3, 2022 · 1 comment
Closed
Tracked by #554

Add check for redundant relays and treat them as noops (although an event must be emitted) in AcknowledgePacket and timeoutOnClose #213

plafer opened this issue Nov 3, 2022 · 1 comment
Labels
A: bug Admin: something isn't working

Comments

@plafer
Copy link
Contributor

plafer commented Nov 3, 2022 •
edited
Loading 

    Unrelated to this PR, but I think we need to check for redundant relays and treat them as noops (although an event must be emitted) -> https://github.com/cosmos/ibc-go/blob/a0e59b8e7a2e1305b7b168962e20516ca8c98fad/modules/core/04-channel/keeper/packet.go#L419-L426

Originally posted by @hu55a1n1 in #198 (comment)

timeoutOnClose comment
@plafer plafer mentioned this issue Nov 3, 2022
Merged
8 tasks
@hu55a1n1 hu55a1n1 added the A: bug Admin: something isn't working label Nov 7, 2022
@Farhad-Shabani Farhad-Shabani mentioned this issue Mar 17, 2023
Open
@plafer
Copy link
Contributor Author

plafer commented Mar 28, 2023 •
edited
Loading

this was resolved in the Validation/ExecutionContext API implementation (e.g. here for AcknowledgePacket).

@plafer plafer closed this as completed Mar 28, 2023
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
@dependabot @crodriguezvega
chore: bump @types/jasmine from 4.3.6 to 5.1.1 in /js (informalsystem…
bddfdfc 
…s#213)

Bumps [@types/jasmine](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jasmine) from 4.3.6 to 5.1.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jasmine)

---
updated-dependencies:
- dependency-name: "@types/jasmine"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Carlos Rodriguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: bug Admin: something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plafer @hu55a1n1