Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document HTTP basic auth in the help page of the guide #2508

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Document HTTP basic auth in the help page of the guide #2508

merged 1 commit into from
Aug 3, 2022

Conversation

romac
Copy link
Member

@romac romac commented Aug 2, 2022

See: #2459

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac requested a review from adizere August 2, 2022 14:24
@romac
Copy link
Member Author

romac commented Aug 2, 2022

I will add a changelog entry for #2508 and close it in the PR where we do the update to the next version of tendermint-rs which includes the fix for basic auth.

adizere
adizere approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, very clear!

@romac romac mentioned this pull request Aug 3, 2022
Closed
6 tasks
@romac romac merged commit 3b31183 into master Aug 3, 2022
@romac romac deleted the romac/2459-basic-auth branch August 3, 2022 11:54
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@romac
Document HTTP basic auth in the help page of the guide (informalsyste…
401ce7e 
…ms#2508)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romac @adizere