Remove Deserialize from IbcEvent (#2482)

* Remove deserialize * changelog
informalsystems · Jul 29, 2022 · f1d51d1 · f1d51d1
1 parent 76d7551
commit f1d51d1
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 23 deletions.
diff --git a/.changelog/unreleased/improvements/ibc/2481-remove-deserialize-ibcevent b/.changelog/unreleased/improvements/ibc/2481-remove-deserialize-ibcevent
@@ -0,0 +1,3 @@
+- Remove Deserialize from IbcEvent and variants ([#2481])
+
+[#2481]: https://github.com/informalsystems/ibc-rs/issues/2481
diff --git a/modules/src/core/ics02_client/events.rs b/modules/src/core/ics02_client/events.rs
@@ -28,7 +28,7 @@ pub const HEADER_ATTRIBUTE_KEY: &str = "header";
 
 /// NewBlock event signals the committing & execution of a new block.
 // TODO - find a better place for NewBlock
-#[derive(Debug, Deserialize, Serialize, Clone, Copy, PartialEq, Eq)]
+#[derive(Debug, Serialize, Clone, Copy, PartialEq, Eq)]
 pub struct NewBlock {
     pub height: Height,
 }
@@ -111,7 +111,7 @@ impl core::fmt::Display for Attributes {
 }
 
 /// CreateClient event signals the creation of a new on-chain client (IBC client).
-#[derive(Debug, Deserialize, Serialize, Clone, PartialEq, Eq)]
+#[derive(Debug, Serialize, Clone, PartialEq, Eq)]
 pub struct CreateClient(pub Attributes);
 
 impl CreateClient {
@@ -155,7 +155,7 @@ impl core::fmt::Display for CreateClient {
 }
 
 /// UpdateClient event signals a recent update of an on-chain client (IBC Client).
-#[derive(Deserialize, Serialize, Clone, PartialEq, Eq)]
+#[derive(Serialize, Clone, PartialEq, Eq)]
 pub struct UpdateClient {
     pub common: Attributes,
     pub header: Option<AnyHeader>,
@@ -229,7 +229,7 @@ impl core::fmt::Debug for UpdateClient {
 
 /// ClientMisbehaviour event signals the update of an on-chain client (IBC Client) with evidence of
 /// misbehaviour.
-#[derive(Debug, Deserialize, Serialize, Clone, PartialEq, Eq)]
+#[derive(Debug, Serialize, Clone, PartialEq, Eq)]
 pub struct ClientMisbehaviour(pub Attributes);
 
 impl ClientMisbehaviour {
@@ -267,7 +267,7 @@ impl From<ClientMisbehaviour> for AbciEvent {
 }
 
 /// Signals a recent upgrade of an on-chain client (IBC Client).
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Hash, Deserialize, Serialize)]
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Hash, Serialize)]
 pub struct UpgradeClient(pub Attributes);
 
 impl UpgradeClient {

diff --git a/modules/src/core/ics03_connection/events.rs b/modules/src/core/ics03_connection/events.rs
@@ -81,7 +81,7 @@ impl From<Attributes> for Vec<Tag> {
     }
 }
 
-#[derive(Debug, Deserialize, Serialize, Clone, PartialEq, Eq)]
+#[derive(Debug, Serialize, Clone, PartialEq, Eq)]
 pub struct OpenInit(Attributes);
 
 impl OpenInit {
@@ -121,7 +121,7 @@ impl From<OpenInit> for AbciEvent {
     }
 }
 
-#[derive(Debug, Deserialize, Serialize, Clone, PartialEq, Eq)]
+#[derive(Debug, Serialize, Clone, PartialEq, Eq)]
 pub struct OpenTry(Attributes);
 
 impl OpenTry {
@@ -161,7 +161,7 @@ impl From<OpenTry> for AbciEvent {
     }
 }
 
-#[derive(Debug, Deserialize, Serialize, Clone, PartialEq, Eq)]
+#[derive(Debug, Serialize, Clone, PartialEq, Eq)]
 pub struct OpenAck(Attributes);
 
 impl OpenAck {
@@ -201,7 +201,7 @@ impl From<OpenAck> for AbciEvent {
     }
 }
 
-#[derive(Debug, Deserialize, Serialize, Clone, PartialEq, Eq)]
+#[derive(Debug, Serialize, Clone, PartialEq, Eq)]
 pub struct OpenConfirm(Attributes);
 
 impl OpenConfirm {

diff --git a/modules/src/core/ics04_channel/events.rs b/modules/src/core/ics04_channel/events.rs
@@ -183,7 +183,7 @@ pub trait EventType {
     fn event_type() -> IbcEventType;
 }
 
-#[derive(Debug, Deserialize, Serialize, Clone, PartialEq, Eq)]
+#[derive(Debug, Serialize, Clone, PartialEq, Eq)]
 pub struct OpenInit {
     pub height: Height,
     pub port_id: PortId,
@@ -233,7 +233,7 @@ impl EventType for OpenInit {
     }
 }
 
-#[derive(Debug, Deserialize, Serialize, Clone, PartialEq, Eq)]
+#[derive(Debug, Serialize, Clone, PartialEq, Eq)]
 pub struct OpenTry {
     pub height: Height,
     pub port_id: PortId,
@@ -282,7 +282,7 @@ impl EventType for OpenTry {
     }
 }
 
-#[derive(Debug, Deserialize, Serialize, Clone, PartialEq, Eq)]
+#[derive(Debug, Serialize, Clone, PartialEq, Eq)]
 pub struct OpenAck {
     pub height: Height,
     pub port_id: PortId,
@@ -336,7 +336,7 @@ impl EventType for OpenAck {
     }
 }
 
-#[derive(Debug, Deserialize, Serialize, Clone, PartialEq, Eq)]
+#[derive(Debug, Serialize, Clone, PartialEq, Eq)]
 pub struct OpenConfirm {
     pub height: Height,
     pub port_id: PortId,
@@ -386,7 +386,7 @@ impl EventType for OpenConfirm {
     }
 }
 
-#[derive(Debug, Deserialize, Serialize, Clone, PartialEq, Eq)]
+#[derive(Debug, Serialize, Clone, PartialEq, Eq)]
 pub struct CloseInit {
     pub height: Height,
     pub port_id: PortId,
@@ -477,7 +477,7 @@ impl EventType for CloseInit {
     }
 }
 
-#[derive(Debug, Deserialize, Serialize, Clone, PartialEq, Eq)]
+#[derive(Debug, Serialize, Clone, PartialEq, Eq)]
 pub struct CloseConfirm {
     pub height: Height,
     pub channel_id: Option<ChannelId>,
@@ -569,7 +569,7 @@ impl_from_ibc_to_abci_event!(
     CloseConfirm
 );
 
-#[derive(Deserialize, Serialize, Clone, PartialEq, Eq)]
+#[derive(Serialize, Clone, PartialEq, Eq)]
 pub struct SendPacket {
     pub height: Height,
     pub packet: Packet,
@@ -626,7 +626,7 @@ impl core::fmt::Debug for SendPacket {
     }
 }
 
-#[derive(Debug, Deserialize, Serialize, Clone, PartialEq, Eq)]
+#[derive(Debug, Serialize, Clone, PartialEq, Eq)]
 pub struct ReceivePacket {
     pub height: Height,
     pub packet: Packet,
@@ -677,7 +677,7 @@ impl core::fmt::Display for ReceivePacket {
     }
 }
 
-#[derive(Deserialize, Serialize, Clone, PartialEq, Eq)]
+#[derive(Serialize, Clone, PartialEq, Eq)]
 pub struct WriteAcknowledgement {
     pub height: Height,
     pub packet: Packet,
@@ -752,7 +752,7 @@ impl core::fmt::Debug for WriteAcknowledgement {
     }
 }
 
-#[derive(Deserialize, Serialize, Clone, PartialEq, Eq)]
+#[derive(Serialize, Clone, PartialEq, Eq)]
 pub struct AcknowledgePacket {
     pub height: Height,
     pub packet: Packet,
@@ -803,7 +803,7 @@ impl core::fmt::Debug for AcknowledgePacket {
     }
 }
 
-#[derive(Debug, Deserialize, Serialize, Clone, PartialEq, Eq)]
+#[derive(Debug, Serialize, Clone, PartialEq, Eq)]
 pub struct TimeoutPacket {
     pub height: Height,
     pub packet: Packet,
@@ -854,7 +854,7 @@ impl core::fmt::Display for TimeoutPacket {
     }
 }
 
-#[derive(Debug, Deserialize, Serialize, Clone, PartialEq, Eq)]
+#[derive(Debug, Serialize, Clone, PartialEq, Eq)]
 pub struct TimeoutOnClosePacket {
     pub height: Height,
     pub packet: Packet,

diff --git a/modules/src/events.rs b/modules/src/events.rs
@@ -214,7 +214,7 @@ impl FromStr for IbcEventType {
 }
 
 /// Events created by the IBC component of a chain, destined for a relayer.
-#[derive(Debug, Clone, Deserialize, Serialize, PartialEq, Eq)]
+#[derive(Debug, Clone, Serialize, PartialEq, Eq)]
 pub enum IbcEvent {
     NewBlock(NewBlock),
 
@@ -457,7 +457,7 @@ impl IbcEvent {
     }
 }
 
-#[derive(Debug, Clone, Deserialize, Serialize, PartialEq, Eq)]
+#[derive(Debug, Clone, Serialize, PartialEq, Eq)]
 pub struct ModuleEvent {
     pub kind: String,
     pub module_name: ModuleId,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		- Remove Deserialize from IbcEvent and variants ([#2481])

		[#2481]: https://github.com/informalsystems/ibc-rs/issues/2481