Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: automerge zac components #2461

Merged
merged 2 commits into from
Jan 21, 2025
Merged

fix: automerge zac components #2461

merged 2 commits into from
Jan 21, 2025

Conversation

niorg
Copy link
Member

@niorg niorg commented Jan 21, 2025

This should hopefully fix the renovate automerging of zac components

Solves PZ-5122

@niorg niorg requested review from hsiliev and a team as code owners January 21, 2025 11:01
Copy link
Contributor

github-actions bot commented Jan 21, 2025

unit-test-results

 79 files  ±0  109 suites  ±0   2m 2s ⏱️ -2s
375 tests ±0  374 ✅ ±0  1 💤 ±0  0 ❌ ±0 
467 runs  ±0  465 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit e26d6a9. ± Comparison against base commit e610fb8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 21, 2025

integration-test-results

 27 files  ±0   27 suites  ±0   34s ⏱️ ±0s
106 tests ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 
119 runs  ±0  119 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e26d6a9. ± Comparison against base commit e610fb8.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.73%. Comparing base (e610fb8) to head (e26d6a9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2461   +/-   ##
=========================================
  Coverage     53.73%   53.73%           
  Complexity     3274     3274           
=========================================
  Files           999      999           
  Lines         22714    22714           
  Branches       1768     1775    +7     
=========================================
  Hits          12206    12206           
  Misses         9611     9611           
  Partials        897      897           
Flag Coverage Δ
integrationtests 49.20% <ø> (ø)
unittests 34.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niorg
Copy link
Member Author

niorg commented Jan 21, 2025

Disabled bumpVersion for now after a question from @infonl-marcel

It was intended for helm chart updates, but is not working yet (waiting for renovatebot/renovate#4728)

@niorg niorg added this pull request to the merge queue Jan 21, 2025
@bas-info-nl
Copy link
Member

This should hopefully fix the renovate automerging of zac components

I'm not sure what this exactly means, but the process we agreed on for Renovate PRs is:

  1. PRs are created by Renovate 🤖 for updates that it detected
  2. These PRs are automatically "approved" ✅ by Renovate 🤖
  3. Our Hero 🦸 checks if the PRs are good to merge 💚
  4. The Hero 🦸 manually presses the merge button 🚀

@bas-info-nl bas-info-nl removed this pull request from the merge queue due to a manual request Jan 21, 2025
Copy link
Member

@bas-info-nl bas-info-nl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure this is the process we need !

github-actions bot pushed a commit that referenced this pull request Jan 21, 2025
This should hopefully fix the renovate automerging of zac components

Solves PZ-5122

---------

Co-authored-by: Cyril Roos <[email protected]>
@niorg
Copy link
Member Author

niorg commented Jan 21, 2025

No other components will be auto-merged. Only the version number of zaakafhandelcomponent itself in publiccode.yaml.

@bas-info-nl bas-info-nl added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 50cb7ee Jan 21, 2025
23 checks passed
@bas-info-nl bas-info-nl deleted the bugfix/automerge_zac branch January 21, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants