Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Use cargo 1.84 feature to check MSRV #160

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

CI: Use cargo 1.84 feature to check MSRV #160

wants to merge 15 commits into from

Conversation

msrd0
Copy link
Collaborator

@msrd0 msrd0 commented Jan 23, 2025 •
edited
Loading

https://blog.rust-lang.org/2025/01/09/Rust-1.84.0.html#cargo-considers-rust-versions-for-dependency-version-selection

Our MSRV is currently 1.65, otherwise we cannot find a candidate for the regex-syntax crate which is a transitive dependency.

@msrd0 msrd0 marked this pull request as ready for review January 23, 2025 23:32
@msrd0 msrd0 mentioned this pull request Jan 23, 2025
Closed
7 tasks
@msrd0 msrd0 requested a review from Empty2k12 January 23, 2025 23:41
Empty2k12
Empty2k12 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@Empty2k12 Empty2k12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does indeed look like a better solution. Thanks for figuring and also building it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Empty2k12 Empty2k12 Empty2k12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msrd0 @Empty2k12