Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wirey version #17

Merged
merged 1 commit into from
May 4, 2018
Merged

Wirey version #17

merged 1 commit into from
May 4, 2018

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented May 4, 2018

Wirey now has a version command wirey version and send wirey/version as user agent when calling http backends.
Closes #16

Signed-off-by: Lorenzo Fontana <[email protected]>

Version command

Signed-off-by: Lorenzo Fontana <[email protected]>

No need to change that

Signed-off-by: Lorenzo Fontana <[email protected]>
@gianarb
Copy link

gianarb commented May 4, 2018

is it still working if I do go run main.go or is it going to panic?

@fntlnz
Copy link
Contributor Author

fntlnz commented May 4, 2018

@gianarb it is not a pointer so it works, it simply does not report any version

@gianarb gianarb self-requested a review May 4, 2018 10:31
@fntlnz fntlnz merged commit e9a5075 into master May 4, 2018
@fntlnz fntlnz deleted the wirey-version branch May 4, 2018 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants