Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated and unused SetAggregate() and IsAggregate() functions. #8994

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Mar 16, 2021

Required for all PRs:

  • Associated README.md updated.
  • Has appropriate unit tests.

The mentioned functions are deprecated, their use was discouraged and they are not used anywhere anymore. According to a comment of @reimda in PR #8183 those functions should be removed.

Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

Copy link
Member

@helenosheaa helenosheaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@zak-pawel zak-pawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zak-pawel zak-pawel added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 17, 2021
@helenosheaa
Copy link
Member

@srebhan can you resolve the conflict?

@srebhan srebhan force-pushed the remove_set_is_aggregate branch from 244adb4 to 17d29e6 Compare April 6, 2021 09:46
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reimda reimda merged commit 5524acf into influxdata:master Apr 6, 2021
@srebhan srebhan deleted the remove_set_is_aggregate branch April 12, 2021 08:28
jblesener pushed a commit to jblesener/telegraf that referenced this pull request Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants