Revive fixes - part 3 #8872
Merged
Revive fixes - part 3 #8872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[rule.var-naming]
![telegraf-tiger[bot]](https://avatars.githubusercontent.com/in/94907?s=60&v=4){kind=small}
srebhan
reviewed
Feb 17, 2021
srebhan
reviewed
Feb 17, 2021
srebhan
reviewed
Feb 17, 2021
srebhan
reviewed
Feb 17, 2021
srebhan
reviewed
Feb 17, 2021
srebhan
reviewed
Feb 17, 2021
srebhan
approved these changes
Feb 17, 2021
|
!retry-checks |
|
!retry-failed |
srebhan
added
the
ready for final review
ssoroka
approved these changes
Mar 1, 2021
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
* * Revive fixes regarding following set of rules: [rule.var-naming]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revive is fast, configurable, extensible, flexible, and beautiful linter for Go. Drop-in replacement of golint.
This is part3 of fixes for problems found for following set of rules:
don't use an underscore in package nameissues were not fixed -> Telegraf allows to have underscores in package names. This approach should be rethought or having underscores in packages should be ignored.