Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add query of pull-request statistics to github input #8500

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Add query of pull-request statistics to github input #8500

merged 3 commits into from
Dec 10, 2020

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Dec 2, 2020

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

This adds the possibility to query the number of "open" and "closed" pull-requests from a GitHub repository. We hide this behind a new additional_fields option to limit the effect to the rate-limit as two new queries are necessary for the new fields.

p-zak
p-zak reviewed Dec 2, 2020
View reviewed changes
@sjwang90 sjwang90 added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Dec 3, 2020
@p-zak p-zak added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 3, 2020
@p-zak
Copy link
Collaborator

p-zak commented Dec 3, 2020

LGTM!

reimda
reimda suggested changes Dec 8, 2020
View reviewed changes
@ssoroka ssoroka merged commit 34151c4 into influxdata:master Dec 10, 2020
@reimda reimda changed the title [inputs.github] Add query of pull-request statistics Add query of pull-request statistics to github input Dec 10, 2020
ssoroka pushed a commit that referenced this pull request Dec 16, 2020
@srebhan @ssoroka
[inputs.github] Add query of pull-request statistics (#8500)
3c5fbd2 
(cherry picked from commit 34151c4)
@srebhan srebhan deleted the github_pr branch April 12, 2021 08:30
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@srebhan
[inputs.github] Add query of pull-request statistics (influxdata#8500)
88d6ad8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-zak p-zak p-zak left review comments

@reimda reimda reimda approved these changes

Assignees
No one assigned
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srebhan @p-zak @reimda @ssoroka @sjwang90