Add prometheus remote write serializer #8360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ssoroka I create a new PR for explore remote write serializer if we prefer or not a dedicated serializer. This serializer use some functions from Prometheus serializer when it's possible. sometime it's the same fonction copied with type changed |
aarnaud
force-pushed
the
feat/remote-write-serializer
branch
2 times, most recently
from
f7cfccb to
d287e96
Compare
aarnaud
changed the title
|
@ssoroka I think dedicated serializer is less intrusive and more maintainable |
aarnaud
force-pushed
the
feat/remote-write-serializer
branch
from
d287e96 to
b5d7a30
Compare
3 tasks
|
Thanks for this. Will review it shortly. |
ssoroka
reviewed
Dec 2, 2020
plugins/serializers/prometheus_remote_write/prometheus_remote_write.go
Outdated
Show resolved
Hide resolved
plugins/serializers/prometheus_remote_write/prometheus_remote_write.go
Outdated
Show resolved
Hide resolved
aarnaud
force-pushed
the
feat/remote-write-serializer
branch
from
0568171 to
2be0757
Compare
ssoroka
approved these changes
Dec 2, 2020
|
Hi, I was curious if there were plans to get this merged in. Thanks! |
|
who can merge because this PR is approved ? |
|
thanks @ssorathia ;-) |
ssoroka
pushed a commit
that referenced
this pull request
Dec 16, 2020
(cherry picked from commit 045c3c1)
tsharju
pushed a commit
to aiven/telegraf
that referenced
this pull request
Jan 8, 2021
3 tasks
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Related to #8346
Depends if we prefer used a dedicated serializer or not