RAS plugin - fix for too many open files handlers #8306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Details
Database driver doesn't close file handler properly when
db.Close()
is called.This may lead to
too many open files
for Telegraf process (returned by OS).In this fix
sql.Open()
is called once inStart()
anddb.Close()
is also called only once inStop()
.This is also optimization (open DB just once, not in every
Gather()
) and following along guide from comment forfunc (db *DB) Close() error
insql.go
:The same approach was introduced in
inputs/postgresql
plugin.