Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set, and histogram reporting to aerospike telegraf plugin #8025

Merged
merged 2 commits into from
Aug 28, 2020
Merged

Add set, and histogram reporting to aerospike telegraf plugin #8025

merged 2 commits into from
Aug 28, 2020

Conversation

grossjo
Copy link
Contributor

@grossjo grossjo commented Aug 24, 2020

refactored to allow non integration tests
fix tests to work with aerospike 4.9.0.11

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

refactored to allow non integration tests
fix tests to work with aerospike 4.9.0.11
@ssoroka
Copy link
Contributor

ssoroka commented Aug 24, 2020

Thanks!

Looks like github.com/influxdata/telegraf/plugins/inputs/net_response failed, but only on darwin. Going to rerun it to see if it was just an intermittent fluke.

Will review

@ssoroka ssoroka self-assigned this Aug 24, 2020
@ssoroka ssoroka self-requested a review August 24, 2020 16:04
@grossjo
Copy link
Contributor Author

grossjo commented Aug 24, 2020

I attempted to make it backwards compatible, where all new features are opt-in.
Which should be good for any existing users of this plugin.

@grossjo
Copy link
Contributor Author

grossjo commented Aug 26, 2020

Hi,
Just wondering what it would take to get this merged in?

Copy link
Contributor

@ssoroka ssoroka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have 2 comments you can optional address. I'll merge when you're ready.

a.NumberHistogramBuckets = 100
} else if a.NumberHistogramBuckets < 1 {
a.NumberHistogramBuckets = 10
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You inherited this, but there's an opportunity to clean it up. plugins can have an Init() function that allows you to do init and config related things that runs once and before the first Gather call.

Just add func (a *Aerospike) Init() error { and you can move all this setup-related stuff there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe next time we do more work, we'll update this. Did not have time this iteration

plugins/inputs/aerospike/aerospike.go Show resolved Hide resolved
@grossjo
Copy link
Contributor Author

grossjo commented Aug 26, 2020

I'll add the init function, Didn't know about that.
Give me a day.

@grossjo
Copy link
Contributor Author

grossjo commented Aug 28, 2020

All changes we are going to do this time are pushed up. If you are good with this PR, feel free to merge.

@ssoroka ssoroka added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Aug 28, 2020
@ssoroka ssoroka merged commit 4ebb8c7 into influxdata:master Aug 28, 2020
@ssoroka
Copy link
Contributor

ssoroka commented Aug 28, 2020

Thanks, Josh :)

idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants