Export internal/tls package for use in execd plugins #7697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssoroka
approved these changes
Jun 17, 2020
|
Looking in internal/ there is other code that is useful in plugins. A quick grep shows plugins using tls most but also rcon, limiter, docker, globpath, syslog, rotate, etc. internal.Duration is used everywhere. If we fix just tls we're going to have other execd plugin writers request these as they need them. Should we make a more comprehensive fix that covers more of the code in internal? |
|
Some of these should be exposed but I can do them in separate pull requests. |
|
fyi @reimda internal.Duration is deprecated in favor of config.Duration, it just hasn't been removed from the project yet. |
reimda
approved these changes
Jun 23, 2020
3 tasks
rhajek
pushed a commit
to bonitoo-io/telegraf
that referenced
this pull request
Jul 13, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7687
Required for all PRs: