Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source field for icinga2 plugin (#7004) #7651

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

abracadv8
Copy link
Contributor

@abracadv8 abracadv8 commented Jun 8, 2020

The plugin uses the icinga2 server name, but does not provide the actual host the check is running on.

This fixes that by adding a new field called server, where server is the icinga2 server and source is hostname of the service or host object that icinga2 performing the checks on.

closes #7004

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

The plugin uses the icinga2 server name, but does not provide the actual host the check is running on.

This fixes that by adding a new field called `server`, where `server` is the icinga2 server and `source` is hostname of the service or host object that icinga2 performing the checks on.
@danielnelson danielnelson added this to the 1.15.0 milestone Jun 8, 2020
@danielnelson danielnelson added fix pr to fix corresponding bug feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Jun 8, 2020
@danielnelson danielnelson merged commit 073cb9b into influxdata:master Jun 8, 2020
rhajek pushed a commit to bonitoo-io/telegraf that referenced this pull request Jul 13, 2020
The plugin uses the icinga2 server name, but does not provide the actual host the check is running on.

This fixes that by adding a new field called `server`, where `server` is the icinga2 server and `source` is hostname of the service or host object that icinga2 performing the checks on.
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
The plugin uses the icinga2 server name, but does not provide the actual host the check is running on.

This fixes that by adding a new field called `server`, where `server` is the icinga2 server and `source` is hostname of the service or host object that icinga2 performing the checks on.
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
The plugin uses the icinga2 server name, but does not provide the actual host the check is running on.

This fixes that by adding a new field called `server`, where `server` is the icinga2 server and `source` is hostname of the service or host object that icinga2 performing the checks on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

icinga2 inputs module not reporting affected asset hostname
2 participants