[output.wavefront] Added truncate_tags setting #7503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing to consider is if we think the new option should remain long term, or if we want to push users towards truncate being true and eventually remove the setting entirely. Depending on what you think it may be worth adding a log message to suggest setting the option. |
rhajek
pushed a commit
to bonitoo-io/telegraf
that referenced
this pull request
Jul 13, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Fixes #7447
The total length of tag key + tag value isn't allowed to exceed 254 characters when sending metrics to Wavefront. By default, these metrics are discarded by wavefront. The new
truncate_tagsflag in the configuration file causes the Wavefront output to truncate the tag value so that the length of the key + value never exceeds 254. If the tag key is longer than 254 characters, the metric point is dropped and a warning is logged.The
truncate_tagsflag is turned off by default to ensure backwards compatibility.