7403 - Allow to collect HTTP Headers thanks to http_response #7405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think about making this look more similar to the new |
danielnelson
added
the
feat
|
@danielnelson thx for the feedback, here is a new version based on what has been done in the |
|
@danielnelson could you please tell me if this new version of the PR is what you had in mind? |
danielnelson
suggested changes
May 22, 2020
| @@ -239,6 +245,14 @@ func (h *HTTPResponse) httpGather(u string) (map[string]interface{}, map[string] | |||
| resp, err := h.client.Do(request) | |||
| response_time := time.Since(start).Seconds() | |||
|
|
|||
| // Add the response headers | |||
| for headerName, measurementName := range h.HTTPHeaderTags { | |||
There was a problem hiding this comment.
Rename measurementName -> tagKey or just tag. This will reduce confusion against the metric measurement/name.
There was a problem hiding this comment.
@danielnelson done, please check again
danielnelson
approved these changes
May 26, 2020
|
@danielnelson thanks :-) |
jaecktec
pushed a commit
to jaecktec/telegraf
that referenced
this pull request
Jun 8, 2020
rhajek
pushed a commit
to bonitoo-io/telegraf
that referenced
this pull request
Jul 13, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7403
Required for all PRs: