-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove init checks for valid label and field selectors #7198
Conversation
Including these libraries starts a goroutine at init time.
cc @mg03 |
@danielnelson : thank you qs: I'm assuming the goroutine launched by klog is not an acceptable. can you please help me understand why ? |
That's right, it appears that this goroutine is launched during package init so even if you are not using the prometheus input it is started. You can imagine that if every plugin did this it would be quite a mess. I haven't looked into why this goroutine is launched, if it were optional or if we could control when it starts and stops we could add these checks back. |
@danielnelson : I agree and have reached out to the creator of the packages on GitHub and asked them the qs of either not importing the dependency or control the start/stop of the goroutine. In the meantime, runtime failure should be acceptable since the code snippets were testing input format and should not have any detrimental effect on usability of the PR I submitted initially. |
Importing k8s.io/klog starts a long running goroutine at init time.
Importing k8s.io/klog starts a long running goroutine at init time.
Importing k8s.io/klog starts a long running goroutine at init time.
Importing k8s.io/klog starts a long running goroutine at init time.
Importing k8s.io/klog starts a long running goroutine at init time.
Importing k8s.io/klog starts a long running goroutine at init time.
Importing these libraries starts a goroutine at init time. The removal of the checks will push a startup time error to a runtime error.
related #6969
Required for all PRs: