Added the ability to set the endpoint url in the configuration file #7134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssoroka
suggested changes
Mar 9, 2020
ssoroka
approved these changes
Mar 11, 2020
| func NewTransmitter(ikey string) *Transmitter { | ||
| return &Transmitter{client: appinsights.NewTelemetryClient(ikey)} | ||
| func NewTransmitter(ikey string, endpointURL string) *Transmitter { | ||
| if len(endpointURL) == 0 { |
There was a problem hiding this comment.
You could simplify this function to:
func NewTransmitter(ikey string, endpointURL string) *Transmitter {
telemetryConfig := appinsights.NewTelemetryConfiguration(ikey)
telemetryConfig.EndpointUrl = endpointURL
return &Transmitter{client: appinsights.NewTelemetryClientFromConfig(telemetryConfig)}
}
since telemetryConfig.EndpointUrl is likely already an empty string.
There was a problem hiding this comment.
telemetryConfig.EndpointUrl by default = https://dc.services.visualstudio.com/v2/track and if we set it to empty we get error
pmalek-sumo
pushed a commit
to SumoLogic/telegraf
that referenced
this pull request
Aug 20, 2020
pmalek-sumo
pushed a commit
to SumoLogic/telegraf
that referenced
this pull request
Aug 26, 2020
ssoroka
pushed a commit
that referenced
this pull request
Aug 29, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs: